[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [RFC PATCH 0/2] s/size/entries/ when dealing with non-b
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [RFC PATCH 0/2] s/size/entries/ when dealing with non-byte units |
|
Date: |
Thu, 15 Feb 2018 11:09:18 +0100 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 14.02.2018 um 00:33 hat Eric Blake geschrieben:
> I mentioned this while reviewing Berto's series on L2 slice handling;
> this is a first cut at patches that I think are worth doing throughout
> the qcow2 code base if we like the idea.
I agree it's a good change.
While we're at it, something I noticed in your block status series:
If something points to bytes, it should be an 'offset', and if it
points to entries, it's an 'index'. You changed a few things to byte
granularity, but still call them 'index'. Maybe we should clean that up
as well.
Kevin