Re: [Qemu-block] [PATCH v2 7/8] file-posix: account discard operations

[Alberto Garcia]

On Mon 12 Feb 2018 05:19:57 PM CET, Anton Nefedov wrote:
>>> @@ -158,6 +158,11 @@ typedef struct BDRVRawState {
>>>       bool page_cache_inconsistent:1;
>>>       bool has_fallocate;
>>>       bool needs_alignment;
>>> +    struct {
>>> +        int64_t discard_nb_ok;
>>> +        int64_t discard_nb_failed;
>>> +        int64_t discard_bytes_ok;
>>> +    } stats;
>> 
>> Shouldn't this new structure be defined in a header file so other
>> drivers can use it? Or did you define it here because you don't see that
>> happening soon?
>> 
>
> I guess there's no reason to burden the common header files as long as
> it's not really used anywhere else.

Fair enough,

Reviewed-by: Alberto Garcia <address@hidden>

Berto