[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/2] qcow2: Avoid memory over-allocation on comp
Re: [Qemu-block] [PATCH 2/2] qcow2: Avoid memory over-allocation on compressed images
Wed, 21 Feb 2018 16:22:49 +0100
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)
On Wed 21 Feb 2018 04:00:54 PM CET, Eric Blake wrote:
>> - Solution b: the width of the 'compressed cluster size' field is
>> (cluster_bits - 8), that's (cluster_size / 256) sectors.
> Not true. It is (cluster_bits - 9) or (cluster_size / 512).
It's not, it's (cluster_bits - 8), the documentation is wrong, see the
patch that I sent earlier.
s->csize_mask = (1 << (s->cluster_bits - 8)) - 1;
For a 64k cluster (16 bits) the width is 16 - 8 = 8 bits.
That's 2^8 = 256 sectors, and 256 * 512 = 128k, exactly two clusters.
Coming back to your patch, since we know where the compressed data
starts and we know that it's not going to be larger than cluster_size,
we can read [coffset, coffset + cluster_size) and skip the final bytes
of the last sector because we know that we don't need that data.
Or we can read as much as the size field indicates (up to twice the
cluster size) and let the decompression code handle the rest.