[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v8 04/26] iotests: Drop explicit base blockdev i
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v8 04/26] iotests: Drop explicit base blockdev in 191 |
Date: |
Thu, 22 Feb 2018 15:34:11 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 05.02.2018 um 16:18 hat Max Reitz geschrieben:
> Overriding the backing image should result in a json:{} pseudo-filename.
> Then, you can no longer use the commit block job with filename
> parameters. Therefore, do not explicitly add the base and override the
> middle image in iotest 191, since we do not need to anyway. This will
> allow us to continue to use the middle image's filename to identify it.
>
> In the long run, we want block-commit to accept node names for base and
> top (just like block-stream does).
>
> Signed-off-by: Max Reitz <address@hidden>
Is this actually needed once the FIXME in patch 3 is addressed and only
significant fields are considered, or can we revert the patch at the end
of the series?
Once we implement a node-named based blockdev-commit, we'll want to test
both versions here, so it would be good to be able to set a node-name
and still be able to use the filename for the older interface.
Kevin
- Re: [Qemu-block] [PATCH v8 02/26] block: Use children list in bdrv_refresh_filename, (continued)
- [Qemu-block] [PATCH v8 03/26] block: Add BDS.backing_overridden, Max Reitz, 2018/02/05
- Re: [Qemu-block] [PATCH v8 03/26] block: Add BDS.backing_overridden, Kevin Wolf, 2018/02/22
- Re: [Qemu-block] [PATCH v8 03/26] block: Add BDS.backing_overridden, Max Reitz, 2018/02/22
- Re: [Qemu-block] [PATCH v8 03/26] block: Add BDS.backing_overridden, Kevin Wolf, 2018/02/22
- Re: [Qemu-block] [PATCH v8 03/26] block: Add BDS.backing_overridden, Max Reitz, 2018/02/22
- Re: [Qemu-block] [PATCH v8 03/26] block: Add BDS.backing_overridden, Kevin Wolf, 2018/02/22
- Re: [Qemu-block] [PATCH v8 03/26] block: Add BDS.backing_overridden, Max Reitz, 2018/02/22
[Qemu-block] [PATCH v8 04/26] iotests: Drop explicit base blockdev in 191, Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 05/26] block: Respect backing bs in bdrv_refresh_filename, Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 06/26] block: Make path_combine() return the path, Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 07/26] block: bdrv_get_full_backing_filename_from_...'s ret. val., Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 08/26] block: bdrv_get_full_backing_filename's ret. val., Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 09/26] block: Add bdrv_make_absolute_filename(), Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 10/26] block: Fix bdrv_find_backing_image(), Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 11/26] block: Add bdrv_dirname(), Max Reitz, 2018/02/05