[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v8 04/26] iotests: Drop explicit base blockdev i

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH v8 04/26] iotests: Drop explicit base blockdev in 191
Date: Thu, 22 Feb 2018 15:34:11 +0100
User-agent: Mutt/1.9.1 (2017-09-22)

Am 05.02.2018 um 16:18 hat Max Reitz geschrieben:
> Overriding the backing image should result in a json:{} pseudo-filename.
> Then, you can no longer use the commit block job with filename
> parameters.  Therefore, do not explicitly add the base and override the
> middle image in iotest 191, since we do not need to anyway.  This will
> allow us to continue to use the middle image's filename to identify it.
> In the long run, we want block-commit to accept node names for base and
> top (just like block-stream does).
> Signed-off-by: Max Reitz <address@hidden>

Is this actually needed once the FIXME in patch 3 is addressed and only
significant fields are considered, or can we revert the patch at the end
of the series?

Once we implement a node-named based blockdev-commit, we'll want to test
both versions here, so it would be good to be able to set a node-name
and still be able to use the filename for the older interface.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]