[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 20/36] rbd: Remove non-schema options from ru
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v2 20/36] rbd: Remove non-schema options from runtime_opts |
Date: |
Fri, 23 Feb 2018 00:16:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 2018-02-23 00:13, Max Reitz wrote:
> On 2018-02-21 14:53, Kevin Wolf wrote:
>> Instead of the QemuOpts in qemu_rbd_connect(), we want to use QAPI
>> objects. As a preparation, fetch those options directly from the QDict
>> that .bdrv_open() supports in the rbd driver and that are not in the
>> schema.
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
>> ---
>> block/rbd.c | 55 ++++++++++++++++++++++++-------------------------------
>> 1 file changed, 24 insertions(+), 31 deletions(-)
>>
>> diff --git a/block/rbd.c b/block/rbd.c
>> index 4bbcce4eca..2e79c2d1fd 100644
>> --- a/block/rbd.c
>> +++ b/block/rbd.c
>> @@ -326,28 +326,6 @@ static QemuOptsList runtime_opts = {
>> /*
>> * server.* extracted manually, see qemu_rbd_mon_host()
>> */
>> - {
>> - .name = "password-secret",
>> - .type = QEMU_OPT_STRING,
>> - .help = "ID of secret providing the password",
>> - },
>
> Err, did we just forget this in the QAPI schema or is it really not
> supposed to be there?
Ah, we intentionally removed it after it was added. OK, then.
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v2 15/36] file-posix: Support .bdrv_co_create, (continued)
- [Qemu-block] [PATCH v2 17/36] gluster: Support .bdrv_co_create, Kevin Wolf, 2018/02/21
- [Qemu-block] [PATCH v2 18/36] rbd: Fix use after free in qemu_rbd_set_keypairs() error path, Kevin Wolf, 2018/02/21
- [Qemu-block] [PATCH v2 20/36] rbd: Remove non-schema options from runtime_opts, Kevin Wolf, 2018/02/21
- [Qemu-block] [PATCH v2 19/36] rbd: Factor out qemu_rbd_connect(), Kevin Wolf, 2018/02/21
- [Qemu-block] [PATCH v2 16/36] file-win32: Support .bdrv_co_create, Kevin Wolf, 2018/02/21
- [Qemu-block] [PATCH v2 21/36] rbd: Pass BlockdevOptionsRbd to qemu_rbd_connect(), Kevin Wolf, 2018/02/21