[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 14/36] block: x-blockdev-create QMP command

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH v2 14/36] block: x-blockdev-create QMP command
Date: Thu, 22 Feb 2018 17:19:13 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 02/21/2018 07:53 AM, Kevin Wolf wrote:
This adds a synchronous x-blockdev-create QMP command that can create
qcow2 images on a given node name.

We don't want to block while creating an image, so this is not the final
interface in all aspects, but BlockdevCreateOptionsQcow2 and
.bdrv_co_create() are what they actually might look like in the end. In
any case, this should be good enough to test whether we interpret
BlockdevCreateOptions as we should.

Signed-off-by: Kevin Wolf <address@hidden>
  qapi/block-core.json      | 12 ++++++++
  include/block/block_int.h |  2 ++
  block/create.c            | 76 +++++++++++++++++++++++++++++++++++++++++++++++
  block/qcow2.c             |  3 +-
  block/Makefile.objs       |  2 +-
  5 files changed, 93 insertions(+), 2 deletions(-)
  create mode 100644 block/create.c

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]