[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3] qcow2: Replace align_offset() with ROUND_UP(
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH v3] qcow2: Replace align_offset() with ROUND_UP() |
|
Date: |
Fri, 23 Feb 2018 15:03:54 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 2018-02-15 14:10, Alberto Garcia wrote:
> The align_offset() function is equivalent to the ROUND_UP() macro so
> there's no need to use the former. The ROUND_UP() name is also a bit
> more explicit.
>
> This patch uses ROUND_UP() instead of the slower QEMU_ALIGN_UP()
> because align_offset() already requires that the second parameter is a
> power of two.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> v3 is the same as v2, but rebased on top of the current master fixing
> a merge conflict.
> ---
> block/qcow2-bitmap.c | 4 ++--
> block/qcow2-cluster.c | 4 ++--
> block/qcow2-refcount.c | 4 ++--
> block/qcow2-snapshot.c | 10 +++++-----
> block/qcow2.c | 14 +++++++-------
> block/qcow2.h | 6 ------
> 6 files changed, 18 insertions(+), 24 deletions(-)
Thanks, applied to my block branch:
https://github.com/XanClic/qemu/commits/block
Max
signature.asc
Description: OpenPGP digital signature