[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 2/4] qcow2: Document some maximum size constr
Re: [Qemu-block] [PATCH v3 2/4] qcow2: Document some maximum size constraints
Mon, 26 Feb 2018 17:25:54 +0100
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)
On Thu 22 Feb 2018 04:59:20 PM CET, Eric Blake wrote:
> While at it, notice that since we cannot map any virtual cluster to
> any address higher than 64 PB (56 bits) (due to the L1/L2 field
> encoding), it makes little sense to require the refcount table to
> access host offsets beyond that point.
But refcount blocks are not addressed by L2 tables, so in principle it
should be possible to have refcount blocks after the first 64PB.
But I agree that it's a good idea to set that as a maximum possible
physical size of the qcow2 image.
> @@ -341,7 +355,7 @@ Refcount table entry:
> Bit 0 - 8: Reserved (set to 0)
> - 9 - 63: Bits 9-63 of the offset into the image file at which the
> + 9 - 55: Bits 9-55 of the offset into the image file at which the
> refcount block starts. Must be aligned to a cluster
> @@ -349,6 +363,8 @@ Refcount table entry:
> been allocated. All refcounts managed by this refcount
> are 0.
> + 56 - 63: Reserved (set to 0)
Are we not updating REFT_OFFSET_MASK as well?
[Qemu-block] [PATCH v3 4/4] qcow2: Avoid memory over-allocation on compressed images, Eric Blake, 2018/02/22
[Qemu-block] [PATCH v3 3/4] qcow2: Don't allow overflow during cluster allocation, Eric Blake, 2018/02/22