[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 5/9] nbd/client: fix error messages in nbd_handl

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-block] [PATCH 5/9] nbd/client: fix error messages in nbd_handle_reply_err
Date: Thu, 1 Mar 2018 14:38:40 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

16.02.2018 20:38, Eric Blake wrote:
On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote:
1. NBD_REP_ERR_INVALID is not only about length, so, make message more

2. hex format is not very good: it's hard to read something like
    "option a (set meta context)", so switch to dec.

It would be okay as option 0xa; I also want to be sure we match the output in server traces with the output in client traces; for example, I found:

nbd/server.c-                error_setg(errp, "Unsupported option 0x%" PRIx32 " (%s)",
nbd/server.c:                           option, nbd_opt_lookup(option));

So we want consistency through all the call sites, before this patch is ready to go, although I agree we need it.

I think, decimal format for NBD constants is better, as it used in the spec.

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]