Re: [Qemu-block] [PATCH v2 3/7] qcow2: Check L1 table parameters in qcow2_expand_zero_clusters()

[Eric Blake]

On 03/06/2018 10:14 AM, Alberto Garcia wrote:
> This function iterates over all snapshots of a qcow2 file in order to
> expand all zero clusters, but it does not validate the snapshots' L1
> tables first.
>
> We now have a function to take care of this, so let's use it.
>
> We can also take the opportunity to replace the sector-based
> bdrv_read() with bdrv_pread().
>
> Signed-off-by: Alberto Garcia <address@hidden>
> Cc: Eric Blake <address@hidden>
> ---
>   block/qcow2-cluster.c      | 24 +++++++++++++++++-------
>   tests/qemu-iotests/080     |  2 ++
>   tests/qemu-iotests/080.out |  4 ++++
>   3 files changed, 23 insertions(+), 7 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org