[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v4 0/2] block latency histogram

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH v4 0/2] block latency histogram
Date: Fri, 9 Mar 2018 10:37:00 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/09/2018 10:31 AM, Vladimir Sementsov-Ogievskiy wrote:
09.03.2018 18:40, Eric Blake wrote:
On 03/09/2018 09:33 AM, Vladimir Sementsov-Ogievskiy wrote:

Move block_latency_histogram_set from block/accounting.c to
blockdev.c, as it uses qapi type uint64List and this fact breaks

Was the cross file motion necessary, or could you just fix the #includes according to the recent qapi header refactoring?

Looks like it's not as simple..

/tmp/qemu-test/src/include/block/accounting.h:30:10: fatal error: qapi-types.h: No such file or directory
  #include "qapi-types.h

what to do now? Looks like qapi-types are not generated for some builds. So, this version (v4) should take place.

top-level qapi-types.h was replaced by lots of qapi/qapi*.h modular headers. Unfortunately, incremental builds don't delete the stale qapi-types.h that was left in tree from the point prior to the qapi header refactoring.

To get uint64List, use qapi/qapi-builtin-types.h. To get any type defined in a qapi/MODULE.json file, use qapi/qapi-MODULE-types.h.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]