[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 03/19] block/quorum: Remove protocol-related fields
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PULL 03/19] block/quorum: Remove protocol-related fields |
Date: |
Mon, 26 Mar 2018 16:35:44 +0200 |
From: Fabiano Rosas <address@hidden>
The quorum driver is not a protocol so it should implement bdrv_open
instead of bdrv_file_open and not provide a protocol_name.
Attempts to invoke this driver using protocol syntax
(i.e. quorum:<filename:options:...>) will now fail gracefully:
$ qemu-img info quorum:foo
qemu-img: Could not open 'quorum:foo': Unknown protocol 'quorum'
Signed-off-by: Fabiano Rosas <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/quorum.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/quorum.c b/block/quorum.c
index 14333c18aa..cfe484a945 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -1098,11 +1098,10 @@ static void quorum_refresh_filename(BlockDriverState
*bs, QDict *options)
static BlockDriver bdrv_quorum = {
.format_name = "quorum",
- .protocol_name = "quorum",
.instance_size = sizeof(BDRVQuorumState),
- .bdrv_file_open = quorum_open,
+ .bdrv_open = quorum_open,
.bdrv_close = quorum_close,
.bdrv_refresh_filename = quorum_refresh_filename,
--
2.13.6
- [Qemu-block] [PULL 00/19] Block layer patches, Kevin Wolf, 2018/03/26
- [Qemu-block] [PULL 03/19] block/quorum: Remove protocol-related fields,
Kevin Wolf <=
- [Qemu-block] [PULL 01/19] iotests: 163 is not quick, Kevin Wolf, 2018/03/26
- [Qemu-block] [PULL 05/19] block/blkreplay: Remove protocol-related fields, Kevin Wolf, 2018/03/26
- [Qemu-block] [PULL 06/19] include/block/block_int: Document protocol related functions, Kevin Wolf, 2018/03/26
- [Qemu-block] [PULL 02/19] block/replication: Remove protocol_name field, Kevin Wolf, 2018/03/26
- [Qemu-block] [PULL 08/19] vdi: Change 'static' create option to 'preallocation' in QMP, Kevin Wolf, 2018/03/26
- [Qemu-block] [PULL 09/19] vdi: Fix build with CONFIG_VDI_DEBUG, Kevin Wolf, 2018/03/26
- [Qemu-block] [PULL 04/19] block/throttle: Remove protocol-related fields, Kevin Wolf, 2018/03/26
- [Qemu-block] [PULL 07/19] qcow2: Reset free_cluster_index when allocating a new refcount block, Kevin Wolf, 2018/03/26
- [Qemu-block] [PULL 10/19] qemu-iotests: Test vdi image creation with QMP, Kevin Wolf, 2018/03/26
- [Qemu-block] [PULL 13/19] qemu-iotests: Test invalid resize on luks, Kevin Wolf, 2018/03/26