[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/2] Fix error message about compressed clusters
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH 1/2] Fix error message about compressed clusters with OFLAG_COPIED |
Date: |
Tue, 10 Apr 2018 18:45:21 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 10 Apr 2018 06:18:28 PM CEST, Eric Blake wrote:
> On 04/10/2018 11:05 AM, Alberto Garcia wrote:
>> Compressed clusters are not supposed to have the COPIED bit set.
>> "qemu-img check" detects that and prints an error message reporting
>> the number of the affected host cluster. This doesn't make much sense
>> because compressed clusters are not aligned to host clusters, so it
>> would be better to report the offset instead. Plus, the calculation is
>> wrong and it uses the raw L2 entry as if it was simply an offset.
>>
>> This patch fixes the error message and reports the offset of the
>> compressed cluster.
>>
>> Signed-off-by: Alberto Garcia <address@hidden>
>> ---
>> block/qcow2-refcount.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>
> Do we have iotests coverage of this?
I have one half-written, but I was thinking to put it in 214, so I'll
wait until Max's patch is merged.
Berto