qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2] block: simplify code around releasing bitmap


From: John Snow
Subject: Re: [Qemu-block] [PATCH v2] block: simplify code around releasing bitmaps
Date: Thu, 19 Apr 2018 16:57:47 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0


On 03/26/2018 06:40 AM, Paolo Bonzini wrote:
> QLIST_REMOVE does not require walking the list, and once the "bitmap"
> argument is removed from bdrv_do_release_matching_dirty_bitmap_locked
> the code simplifies a lot and it is worth inlining everything in the
> callers of bdrv_do_release_matching_dirty_bitmap.
> 
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

Reviewed-by: John Snow <address@hidden>

> ---
> 
> Notes:
>     v1->v2: improve locking comments [Vladimir]
> 


Thanks, applied to my bitmaps tree:

https://github.com/jnsnow/qemu/commits/bitmaps
https://github.com/jnsnow/qemu.git

--js



reply via email to

[Prev in Thread] Current Thread [Next in Thread]