[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 0/2] block/mirror: Make cancel alwa
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 0/2] block/mirror: Make cancel always cancel pre-READY |
|
Date: |
Tue, 1 May 2018 18:29:52 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/01/2018 05:05 PM, Max Reitz wrote:
Currently, you cannot cancel a mirror job without the @force flag set.
This is intentional once source and target are in sync, but probably not
so much before that happens. The main reason for me thinking this is
because it is an undocumented change in 2.12.0 in respect to 2.11.
Yeah, that definitely feels like a regression worth fixing.
(b76e4458b1eb3c32e9824fe6aa51f67d2b251748 only notes a behavior change
after READY, but not before.)
This series depends on Stefan’s patch “block/mirror: honor ratelimit
again” (which is in Jeff’s queue).
Based-on: <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org