[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PULL 08/37] iscsi: Switch to .bdrv_co_blo
From: |
Peter Maydell |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PULL 08/37] iscsi: Switch to .bdrv_co_block_status() |
Date: |
Tue, 8 May 2018 16:37:45 +0100 |
On 2 March 2018 at 18:54, Kevin Wolf <address@hidden> wrote:
> From: Eric Blake <address@hidden>
>
> We are gradually moving away from sector-based interfaces, towards
> byte-based. Update the iscsi driver accordingly. In this case,
> it is handy to teach iscsi_co_block_status() to handle a NULL map
> and file parameter, even though the block layer passes non-NULL
> values, because we also call the function directly. For now, there
> are no optimizations done based on the want_zero flag.
>
> - *pnum = sector_lun2qemu(lbasd->num_blocks, iscsilun);
> + *pnum = lbasd->num_blocks * iscsilun->block_size;
Hi; following this change Coverity complains (CID1390646) about
this multiplication, which is a 32-bit multiply whose result
is then put into a 64-bit result. Is it intended to be a
64-bit multiply ?
thanks
-- PMM
- Re: [Qemu-block] [Qemu-devel] [PULL 08/37] iscsi: Switch to .bdrv_co_block_status(),
Peter Maydell <=