[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 1/7] qemu-img: Amendment support implies create_o
From: |
Max Reitz |
Subject: |
[Qemu-block] [PATCH v2 1/7] qemu-img: Amendment support implies create_opts |
Date: |
Wed, 9 May 2018 23:00:17 +0200 |
Instead of checking whether a driver has a non-NULL create_opts we
should check whether it supports image amendment in the first place. If
it does, it must have create_opts.
On the other hand, if it does not have create_opts (so it does not
support amendment either), the error message "does not support any
options" is a bit useless. Stating clearly that the driver has no
amendment support whatsoever is probably better.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
qemu-img.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 62b29e7feb..f38aa51166 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -3740,13 +3740,16 @@ static int img_amend(int argc, char **argv)
goto out;
}
- if (!bs->drv->create_opts) {
- error_report("Format driver '%s' does not support any options to
amend",
+ if (!bs->drv->bdrv_amend_options) {
+ error_report("Format driver '%s' does not support option amendment",
fmt);
ret = -1;
goto out;
}
+ /* Every driver supporting amendment must have create_opts */
+ assert(bs->drv->create_opts);
+
create_opts = qemu_opts_append(create_opts, bs->drv->create_opts);
opts = qemu_opts_create(create_opts, NULL, 0, &error_abort);
qemu_opts_do_parse(opts, options, NULL, &err);
--
2.14.3
- [Qemu-block] [PATCH v2 0/7] qemu-img: Improve option help for amend, Max Reitz, 2018/05/09
- [Qemu-block] [PATCH v2 3/7] qemu-option: Pull out "Supported options" print, Max Reitz, 2018/05/09
- [Qemu-block] [PATCH v2 1/7] qemu-img: Amendment support implies create_opts,
Max Reitz <=
- [Qemu-block] [PATCH v2 2/7] block: Add Error parameter to bdrv_amend_options, Max Reitz, 2018/05/09
- [Qemu-block] [PATCH v2 4/7] qemu-img: Add print_amend_option_help(), Max Reitz, 2018/05/09
- [Qemu-block] [PATCH v2 5/7] qemu-img: Recognize no creation support in -o help, Max Reitz, 2018/05/09
- [Qemu-block] [PATCH v2 6/7] iotests: Test help option for unsupporting formats, Max Reitz, 2018/05/09
- [Qemu-block] [PATCH v2 7/7] iotests: Rework 113, Max Reitz, 2018/05/09