Re: [Qemu-block] [PATCH 22/42] job: Move BlockJobCreateFlags to Job

[Max Reitz]

On 2018-05-09 18:26, Kevin Wolf wrote:
> This renames the BlockJobCreateFlags constants, moves a few JOB_INTERNAL
> checks to job_create() and the auto_{finalize,dismiss} fields from
> BlockJob to Job.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  include/block/blockjob.h     | 17 -----------------
>  include/block/blockjob_int.h |  3 +--
>  include/qemu/job.h           | 20 +++++++++++++++++++-
>  block/commit.c               |  2 +-
>  block/mirror.c               |  2 +-
>  block/replication.c          |  4 ++--
>  block/stream.c               |  2 +-
>  blockdev.c                   | 14 +++++++-------
>  blockjob.c                   | 27 +++++++--------------------
>  job.c                        | 11 ++++++++++-
>  qemu-img.c                   |  2 +-
>  tests/test-blockjob-txn.c    |  2 +-
>  tests/test-blockjob.c        |  4 ++--
>  13 files changed, 53 insertions(+), 57 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature