[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 15/20] migration: use local path for local he
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2 15/20] migration: use local path for local headers |
Date: |
Fri, 25 May 2018 13:24:08 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/25/2018 11:48 AM, Michael S. Tsirkin wrote:
When pulling in headers that are in the same directory as C file (as
s/as C/as the C/ (here and in many other messages)
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Missed trimming this out of your commit message.
Or, if you want, on many of these commits, you could be more explicit
about intention:
When pulling in headers that are in the same directory as the C file (as
opposed to one in include/), we prefer to use its relative path without
a directory, rather than relying on the global -I$(SRC_DIR) that may be
removed in a later patch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org