[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/3] ahci: don't schedule unnecessary BH
From: |
Jeff Cody |
Subject: |
Re: [Qemu-block] [PATCH 3/3] ahci: don't schedule unnecessary BH |
Date: |
Thu, 31 May 2018 12:22:39 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, May 30, 2018 at 08:43:23PM -0400, John Snow wrote:
> The comment gives us a hint. *Maybe* we still have something to
> process. Well, why not check?
Heh :)
Reviewed-by: Jeff Cody <address@hidden>
>
> Signed-off-by: John Snow <address@hidden>
> ---
> hw/ide/ahci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index a9558e45e7..380366b038 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -1427,8 +1427,7 @@ static void ahci_cmd_done(IDEDMA *dma)
> /* update d2h status */
> ahci_write_fis_d2h(ad);
>
> - if (!ad->check_bh) {
> - /* maybe we still have something to process, check later */
> + if (ad->port_regs.cmd_issue && !ad->check_bh) {
> ad->check_bh = qemu_bh_new(ahci_check_cmd_bh, ad);
> qemu_bh_schedule(ad->check_bh);
> }
> --
> 2.14.3
>
>
- [Qemu-block] [PATCH 0/3] ahci: fix completion race condition, John Snow, 2018/05/30
- [Qemu-block] [PATCH 3/3] ahci: don't schedule unnecessary BH, John Snow, 2018/05/30
- Re: [Qemu-block] [PATCH 3/3] ahci: don't schedule unnecessary BH,
Jeff Cody <=
- [Qemu-block] [PATCH 2/3] ahci: fix PxCI register race, John Snow, 2018/05/30
- [Qemu-block] [PATCH 1/3] ahci: trim signatures on raise/lower, John Snow, 2018/05/30
- Re: [Qemu-block] [PATCH 0/3] ahci: fix completion race condition, Stefan Hajnoczi, 2018/05/31
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition, Bruce Rogers, 2018/05/31