qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/16] block: Make blockdev-crea


From: no-reply
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/16] block: Make blockdev-create a job and stable API
Date: Tue, 29 May 2018 14:01:01 -0700 (PDT)

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 00/16] block: Make blockdev-create a job and 
stable API

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
122de4416e block/create: Mark blockdev-create stable
a083e7beeb qemu-iotests: Rewrite 213 for blockdev-create job
c947dfa69d qemu-iotests: Rewrite 212 for blockdev-create job
df37241f2a qemu-iotests: Rewrite 211 for blockdev-create job
b2775b9daf qemu-iotests: Rewrite 210 for blockdev-create job
f60be88204 qemu-iotests: Rewrite 207 for blockdev-create job
bafc347497 qemu-iotests: Rewrite 206 for blockdev-create job
868a906170 qemu-iotests: iotests.py helper for non-file protocols
30b2fe3962 qemu-iotests: Add VM.run_job()
eee2106258 qemu-iotests: Add iotests.img_info_log()
bdd0743777 qemu-iotests: Add VM.qmp_log()
f1cc62a518 qemu-iotests: Add VM.get_qmp_events_filtered()
f0c0ceee97 block/create: Make x-blockdev-create a job
d4d0e41747 job: Add error message for failing jobs
763841f94b vhdx: Fix vhdx_co_create() return value
bd60e71ce1 vdi: Fix vdi_co_do_create() return value

=== OUTPUT BEGIN ===
Checking PATCH 1/16: vdi: Fix vdi_co_do_create() return value...
Checking PATCH 2/16: vhdx: Fix vhdx_co_create() return value...
Checking PATCH 3/16: job: Add error message for failing jobs...
Checking PATCH 4/16: block/create: Make x-blockdev-create a job...
Checking PATCH 5/16: qemu-iotests: Add VM.get_qmp_events_filtered()...
Checking PATCH 6/16: qemu-iotests: Add VM.qmp_log()...
Checking PATCH 7/16: qemu-iotests: Add iotests.img_info_log()...
ERROR: line over 90 characters
#42: FILE: tests/qemu-iotests/iotests.py:227:
+        line = re.sub('uuid: [-a-f0-9]+', 'uuid: 
XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX', line)

total: 1 errors, 0 warnings, 30 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 8/16: qemu-iotests: Add VM.run_job()...
Checking PATCH 9/16: qemu-iotests: iotests.py helper for non-file protocols...
Checking PATCH 10/16: qemu-iotests: Rewrite 206 for blockdev-create job...
Checking PATCH 11/16: qemu-iotests: Rewrite 207 for blockdev-create job...
Checking PATCH 12/16: qemu-iotests: Rewrite 210 for blockdev-create job...
Checking PATCH 13/16: qemu-iotests: Rewrite 211 for blockdev-create job...
Checking PATCH 14/16: qemu-iotests: Rewrite 212 for blockdev-create job...
Checking PATCH 15/16: qemu-iotests: Rewrite 213 for blockdev-create job...
Checking PATCH 16/16: block/create: Mark blockdev-create stable...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]