[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 5/7] ide: make ide_transfer_stop idempotent
From: |
John Snow |
Subject: |
[Qemu-block] [PATCH 5/7] ide: make ide_transfer_stop idempotent |
Date: |
Wed, 6 Jun 2018 15:09:53 -0400 |
From: Paolo Bonzini <address@hidden>
There is code checking s->end_transfer_func and it was not taught about
ide_transfer_cancel. We can just use ide_transfer_stop because
s->end_transfer_func is only ever called in the DRQ phase.
ide_transfer_cancel can then be removed, since it would just be
calling ide_transfer_halt.
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: John Snow <address@hidden>
---
hw/ide/core.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 54799ea6fb..9c4864ae54 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -547,10 +547,9 @@ static void ide_cmd_done(IDEState *s)
}
}
-static void ide_transfer_halt(IDEState *s,
- void(*end_transfer_func)(IDEState *))
+static void ide_transfer_halt(IDEState *s)
{
- s->end_transfer_func = end_transfer_func;
+ s->end_transfer_func = ide_transfer_stop;
s->data_ptr = s->io_buffer;
s->data_end = s->io_buffer;
s->status &= ~DRQ_STAT;
@@ -558,15 +557,10 @@ static void ide_transfer_halt(IDEState *s,
void ide_transfer_stop(IDEState *s)
{
- ide_transfer_halt(s, ide_transfer_stop);
+ ide_transfer_halt(s);
ide_cmd_done(s);
}
-static void ide_transfer_cancel(IDEState *s)
-{
- ide_transfer_halt(s, ide_transfer_cancel);
-}
-
int64_t ide_get_sector(IDEState *s)
{
int64_t sector_num;
@@ -1361,7 +1355,7 @@ static bool cmd_nop(IDEState *s, uint8_t cmd)
static bool cmd_device_reset(IDEState *s, uint8_t cmd)
{
/* Halt PIO (in the DRQ phase), then DMA */
- ide_transfer_cancel(s);
+ ide_transfer_halt(s);
ide_cancel_dma_sync(s);
/* Reset any PIO commands, reset signature, etc */
--
2.14.3
- [Qemu-block] [PATCH 0/7] atapi: change unlimited recursion to while loop, John Snow, 2018/06/06
- [Qemu-block] [PATCH 4/7] ide: call ide_cmd_done from ide_transfer_stop, John Snow, 2018/06/06
- [Qemu-block] [PATCH 6/7] atapi: call ide_set_irq before ide_transfer_start, John Snow, 2018/06/06
- [Qemu-block] [PATCH 5/7] ide: make ide_transfer_stop idempotent,
John Snow <=
- [Qemu-block] [PATCH 1/7] libqos/ahci: track sector size, John Snow, 2018/06/06
- [Qemu-block] [PATCH 7/7] ide: introduce ide_transfer_start_norecurse, John Snow, 2018/06/06
- [Qemu-block] [PATCH 2/7] ahci: move PIO Setup FIS before transfer, fix it for ATAPI commands, John Snow, 2018/06/06
- [Qemu-block] [PATCH 3/7] ide: push end_transfer_func out of start_transfer callback, rename callback, John Snow, 2018/06/06
- Re: [Qemu-block] [PATCH 0/7] atapi: change unlimited recursion to while loop, John Snow, 2018/06/06
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/7] atapi: change unlimited recursion to while loop, John Snow, 2018/06/06