Re: [Qemu-block] [PATCH v2 02/10] block: Add blklogwrites

[Eric Blake]

On 06/07/2018 09:40 AM, Ari Sundholm wrote:
> From: Aapo Vienamo <address@hidden>
>
> Implements a block device write logging system, similar to Linux kernel
> device mapper dm-log-writes. The write operations that are performed
> on a block device are logged to a file or another block device. The
> write log format is identical to the dm-log-writes format. Currently,
> log markers are not supported.
>
> This functionality can be used for crash consistency and fs consistency
> testing. By implementing it in qemu, tests utilizing write logs can be
> be used to test non-Linux drivers and older kernels.
>
> The implementation is based on the blkverify and blkdebug block drivers.
>
> Signed-off-by: Aapo Vienamo <address@hidden>
> Signed-off-by: Ari Sundholm <address@hidden>
> ---

> +++ b/qapi/block-core.json
> @@ -2429,12 +2429,12 @@
>   # Since: 2.9
>   ##
>   { 'enum': 'BlockdevDriver',

Missing a comment:

# @blklogwrites: Since 3.0

> -  'data': [ 'blkdebug', 'blkverify', 'bochs', 'cloop', 'copy-on-read',
> -            'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom',
> -            'host_device', 'http', 'https', 'iscsi', 'luks', 'nbd', 'nfs',
> -            'null-aio', 'null-co', 'nvme', 'parallels', 'qcow', 'qcow2', 'qed',
> -            'quorum', 'raw', 'rbd', 'replication', 'sheepdog', 'ssh',
> -            'throttle', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat', 'vxhs' ] }
> +  'data': [ 'blkdebug', 'blklogwrites', 'blkverify', 'bochs', 'cloop',
> +            'copy-on-read', 'dmg', 'file', 'ftp', 'ftps', 'gluster',
> +            'host_cdrom', 'host_device', 'http', 'https', 'iscsi', 'luks',
> +            'nbd', 'nfs', 'null-aio', 'null-co', 'nvme', 'parallels', 'qcow',
> +            'qcow2', 'qed', 'quorum', 'raw', 'rbd', 'replication', 'sheepdog',
> +            'ssh', 'throttle', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat', 'vxhs' ] 
> }
>   
>   ##
>   # @BlockdevOptionsFile:
> @@ -2949,6 +2949,21 @@
>               '*set-state': ['BlkdebugSetStateOptions'] } }
>   
>   ##
> +# @BlockdevOptionsBlklogwrites:
> +#
> +# Driver specific block device options for blklogwrites.
> +#
> +# @raw:     block device
> +#
> +# @log:     block device used to log writes on @raw
> +#
> +# Since: foo

s/foo/3.0/

> +##
> +{ 'struct': 'BlockdevOptionsBlklogwrites',
> +  'data': { 'raw': 'BlockdevRef',
> +            'log': 'BlockdevRef' } }
> +
> +##
>   # @BlockdevOptionsBlkverify:
>   #
>   # Driver specific block device options for blkverify.
> @@ -3443,6 +3458,7 @@
>     'discriminator': 'driver',
>     'data': {
>         'blkdebug':   'BlockdevOptionsBlkdebug',
> +      'blklogwrites': 'BlockdevOptionsBlklogwrites',
>         'blkverify':  'BlockdevOptionsBlkverify',
>         'bochs':      'BlockdevOptionsGenericFormat',
>         'cloop':      'BlockdevOptionsGenericFormat',
> @@ -3971,6 +3987,7 @@
>     'discriminator': 'driver',
>     'data': {
>         'blkdebug':       'BlockdevCreateNotSupported',
> +      'blklogwrites':   'BlockdevCreateNotSupported',
>         'blkverify':      'BlockdevCreateNotSupported',
>         'bochs':          'BlockdevCreateNotSupported',
>         'cloop':          'BlockdevCreateNotSupported',

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org