[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] file-posix: Implement co versions
From: |
no-reply |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] file-posix: Implement co versions of discard/flush |
Date: |
Thu, 21 Jun 2018 12:36:28 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] file-posix: Implement co versions of discard/flush
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
5c6a508b5c file-posix: Implement co versions of discard/flush
=== OUTPUT BEGIN ===
Checking PATCH 1/1: file-posix: Implement co versions of discard/flush...
ERROR: spaces required around that '|' (ctx:VxV)
#123: FILE: block/file-posix.c:2949:
+ QEMU_AIO_DISCARD|QEMU_AIO_BLKDEV);
^
ERROR: code indent should never use tabs
#133: FILE: block/file-posix.c:3053:
+ .bdrv_co_flush_to_disk^I= raw_co_flush_to_disk,$
ERROR: code indent should never use tabs
#143: FILE: block/file-posix.c:3178:
+ .bdrv_co_flush_to_disk^I= raw_co_flush_to_disk,$
ERROR: code indent should never use tabs
#152: FILE: block/file-posix.c:3308:
+ .bdrv_co_flush_to_disk^I= raw_co_flush_to_disk,$
total: 4 errors, 0 warnings, 131 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden