[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PULL 25/26] block: Remove deprecated -dri
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial |
Date: |
Fri, 22 Jun 2018 14:55:02 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben:
>
> On 06/15/2018 04:21 PM, Kevin Wolf wrote:
> > The -drive option serial was deprecated in QEMU 2.10. It's time to
> > remove it.
> >
> > Tests need to be updated to set the serial number with -global instead
> > of using the -drive option.
>
> libvirt 4.5 still creates those (at least on s390x)
>
> <disk type='file' device='disk'>
> <driver name='qemu' type='qcow2' cache='none' io='native' iothread='1'/>
> <source file='/var/lib/libvirt/qemu/image.zhyp137'/>
> <target dev='hda' bus='virtio'/>
> <serial>skel</serial>
> <boot order='1'/>
> <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x0000'/>
> </disk>
>
>
> ->
> [...]
> -drive
> file=/var/lib/libvirt/qemu/image.zhyp137,format=qcow2,if=none,id=drive-virtio-disk0,serial=skel,cache=none,aio=native
> -device
> virtio-blk-ccw,iothread=iothread1,scsi=off,devno=fe.0.0000,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1,write-cache=on
>
> [...]
>
> 2018-06-22T11:25:20.946024Z qemu-system-s390x: -drive
> file=/var/lib/libvirt/qemu/image.zhyp137,format=qcow2,if=none,id=drive-virtio-disk0,serial=skel,cache=none,aio=native:
> Block format 'qcow2' does not support the option 'serial'
> 2018-06-22 11:25:21.098+0000: shutting down, reason=failed
>
> So it seems that this breaks s390x.
Thanks for bringing this up. libvirt should fix this before QEMU 3.0 is
released.
Sadly, it also shows that deprecation warnings in log files go
unnoticed.
Kevin
- [Qemu-block] [PULL 13/26] block: Make remaining uses of qobject input visitor more robust, (continued)
- [Qemu-block] [PULL 13/26] block: Make remaining uses of qobject input visitor more robust, Kevin Wolf, 2018/06/15
- [Qemu-block] [PULL 18/26] check-block-qdict: Rename qdict_flatten()'s variables for clarity, Kevin Wolf, 2018/06/15
- [Qemu-block] [PULL 08/26] qobject: Move block-specific qdict code to block-qdict.c, Kevin Wolf, 2018/06/15
- [Qemu-block] [PULL 24/26] block: Remove deprecated -drive option addr, Kevin Wolf, 2018/06/15
- [Qemu-block] [PULL 23/26] block: Remove deprecated -drive geometry options, Kevin Wolf, 2018/06/15
- [Qemu-block] [PULL 25/26] block: Remove deprecated -drive option serial, Kevin Wolf, 2018/06/15
- Re: [Qemu-block] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Christian Borntraeger, 2018/06/22
- Re: [Qemu-block] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial,
Kevin Wolf <=
- Re: [Qemu-block] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Christian Borntraeger, 2018/06/22
- Re: [Qemu-block] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Christian Borntraeger, 2018/06/22
- Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Daniel P . Berrangé, 2018/06/22
- Re: [Qemu-block] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Kevin Wolf, 2018/06/22
- Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Daniel P . Berrangé, 2018/06/22
- Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Daniel P . Berrangé, 2018/06/25
- Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Kevin Wolf, 2018/06/25
- Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Peter Krempa, 2018/06/25
- Re: [Qemu-block] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Christian Borntraeger, 2018/06/22
- Re: [Qemu-block] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Peter Maydell, 2018/06/22