[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] qcow2: Remove dead check on !r
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] qcow2: Remove dead check on !ret |
|
Date: |
Wed, 27 Jun 2018 10:05:02 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/27/2018 12:57 AM, Fam Zheng wrote:
> In the beginning of the function, we initialize the local variable to 0,
> and in the body of the function, we check the assigned values and exit
> the loop immediately. So here it can never be non-zero.
>
> Reported-by: Kevin Wolf <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> block/qcow2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index a3a3aa2a97..ff23063616 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -1772,7 +1772,7 @@ static coroutine_fn int
> qcow2_handle_l2meta(BlockDriverState *bs,
> while (l2meta != NULL) {
> QCowL2Meta *next;
>
> - if (!ret && link_l2) {
> + if (link_l2) {
> ret = qcow2_alloc_cluster_link_l2(bs, l2meta);
> if (ret) {
> goto out;
>