Re: [Qemu-block] [PATCH v5 8/8] block: Add blklogwrites

[Kevin Wolf]

Am 29.06.2018 um 18:02 hat Ari Sundholm geschrieben:
> On 06/29/2018 03:05 PM, Kevin Wolf wrote:
> > Am 19.06.2018 um 15:43 hat Ari Sundholm geschrieben:
> > > +    s->cur_log_sector = 1;
> > > +    s->nr_entries = 0;
> > 
> > Would it be useful to implement a mode that appends to the log?
> > 
> > In that case, you'd obviously use the sector size from the existing
> > superblock instead of allowing the user to specify something else.
> > 
> 
> Such a mode may indeed be useful. Thank you for the idea. Would it be OK to
> introduce this feature as a separate patch a bit later?

Yes, of course.

> > > +static BlockDriver bdrv_blk_log_writes = {
> > > +    .format_name            = "blklogwrites",
> > > +    .protocol_name          = "blklogwrites",
> > 
> > This is for the blklogwrites:X:Y syntax, which is not supported, so it
> > should be removed.
> > 
> 
> Just protocol_name, I assume? Will remove, thanks.

Right, just protocol_name. format_name is always required.

Kevin