qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH] qapi/block: Document restrictions


From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH] qapi/block: Document restrictions for node names
Date: Mon, 6 Aug 2018 09:19:15 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 08/06/2018 07:37 AM, Kevin Wolf wrote:
blockdev-add fails if an invalid node name is given, so we should
document what a valid node name even is.

Reported-by: Cong Li <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
  qapi/block-core.json | 3 +++
  1 file changed, 3 insertions(+)

Reviewed-by: Eric Blake <address@hidden>


diff --git a/qapi/block-core.json b/qapi/block-core.json
index 62a92fa4f4..fe565ebfaf 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -3563,6 +3563,9 @@
  # @driver:        block driver name
  # @node-name:     the node name of the new node (Since 2.0).
  #                 This option is required on the top level of blockdev-add.
+#                 Valid node names start with an alphabetic character and may
+#                 contain only alphanumeric characters, '-', '.' and '_'. Their
+#                 maximum length is 31 characters.
  # @discard:       discard-related options (default: ignore)
  # @cache:         cache-related options
  # @read-only:     whether the block device should be read-only (default: 
false).


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]