[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 09/17] mirror: Lock AioContext in mirror_co_perf
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH 09/17] mirror: Lock AioContext in mirror_co_perform() |
|
Date: |
Mon, 13 Aug 2018 17:21:35 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-13 16:43, Paolo Bonzini wrote:
> On 13/08/2018 04:19, Max Reitz wrote:
>> Signed-off-by: Max Reitz <address@hidden>
>
> Locking AioContext should not be needed anywhere here. mirror_run is
> called via aio_co_enter or aio_co_wake, so the lock is actually already
> taken every time you call aio_context_acquire.
>
> It was needed only because AIO callbacks do *not* take the lock, but
> it's not needed anymore since the conversion to coroutines.
Uh, nice. Thanks for letting me know! :-)
I'll drop the locks in v2.
Max
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH 02/17] mirror: Make wait_for_any_operation() coroutine_fn, (continued)
- [Qemu-block] [PATCH 03/17] mirror: Pull *_align_for_copy() from *_co_read(), Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 04/17] mirror: Remove bytes_handled, part 1, Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 05/17] mirror: Remove bytes_handled, part 2, Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 06/17] mirror: Create mirror_co_perform(), Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 07/17] mirror: Make mirror_co_zero() nicer, Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 08/17] mirror: Make mirror_co_discard() nicer, Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 09/17] mirror: Lock AioContext in mirror_co_perform(), Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 10/17] mirror: Create mirror_co_alloc_qiov(), Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 11/17] mirror: Inline mirror_write_complete(), part 1, Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 12/17] mirror: Put QIOV locally into mirror_co_read, Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 13/17] mirror: Linearize mirror_co_read(), Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 14/17] mirror: Inline mirror_iteration_done(), Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 15/17] mirror: Release AioCtx before queue_restart_all(), Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 16/17] mirror: Support COR with write-blocking, Max Reitz, 2018/08/12
- [Qemu-block] [PATCH 17/17] iotests: Add test for active mirror with COR, Max Reitz, 2018/08/12