|
From: | Eric Blake |
Subject: | Re: [Qemu-block] [Qemu-devel] [PATCH 2/7] jobs: canonize Error object |
Date: | Mon, 20 Aug 2018 15:03:53 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/17/2018 02:04 PM, John Snow wrote:
Jobs presently use both an Error object in the case of the create job, and char strings in the case of generic errors elsewhere. Unify the two paths as just j->err, and remove the extra argument from job_completed. The integer error code for job_completed is kept for now for use by pre-emptive cancellation. Signed-off-by: John Snow <address@hidden> ---
@@ -535,7 +535,6 @@ void job_drain(Job *job) } }-/** * All jobs must allow a pause point before entering their job proper. This * ensures that jobs can be paused prior to being started, then resumed later.
Spurious hunk? I'm not opposed to consistent choice of how many newlines between functions, although it looks a bit odd in the overall patch.
Reviewed-by: Eric Blake <address@hidden> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |