[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 07/13] tests/blockjob: replace Blockjob with
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH v2 07/13] tests/blockjob: replace Blockjob with Job |
|
Date: |
Mon, 27 Aug 2018 15:36:50 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-24 00:22, John Snow wrote:
> These tests don't actually test blockjobs anymore, they test
> generic Job lifetimes. Change the types accordingly.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> tests/test-blockjob.c | 98
> ++++++++++++++++++++++++++-------------------------
> 1 file changed, 50 insertions(+), 48 deletions(-)
So, uh, it's just a test-job now, basically... Well, apart from the
BlockBackends created to test the ID error paths.
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 00/13] jobs: jobs: Job Exit Refactoring Pt 2, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 06/13] block/commit: refactor stream to use job callbacks, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 07/13] tests/blockjob: replace Blockjob with Job, John Snow, 2018/08/23
- Re: [Qemu-block] [PATCH v2 07/13] tests/blockjob: replace Blockjob with Job,
Max Reitz <=
- [Qemu-block] [PATCH v2 08/13] tests/test-blockjob: remove exit callback, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 04/13] block/commit: refactor commit to use job callbacks, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 03/13] block/stream: add block job creation flags, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 02/13] block/mirror: add block job creation flags, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 09/13] jobs: remove .exit callback, John Snow, 2018/08/23