[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-3.1 v10 01/31] block: Use bdrv_refresh_filen
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH for-3.1 v10 01/31] block: Use bdrv_refresh_filename() to pull |
Date: |
Tue, 28 Aug 2018 14:13:41 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 09 Aug 2018 11:34:58 PM CEST, Max Reitz wrote:
> Before this patch, bdrv_refresh_filename() is used in a pushing manner:
> Whenever the BDS graph is modified, the parents of the modified edges
> are supposed to be updated (recursively upwards). However, that is
> nonviable, considering that we want child changes not to concern
> parents.
>
> Also, in the long run we want a pull model anyway: Here, we would have a
> bdrv_filename() function which returns a BDS's filename, freshly
> constructed.
>
> This patch is an intermediate step. It adds bdrv_refresh_filename()
> calls before every place a BDS.filename value is used. The only
> exceptions are protocol drivers that use their own filename, which
> clearly would not profit from refreshing that filename before.
>
> Also, bdrv_get_encrypted_filename() is removed along the way (as a user
> of BDS.filename), since it is completely unused.
>
> In turn, all of the calls to bdrv_refresh_filename() before this patch
> are removed, because we no longer have to call this function on graph
> changes.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Berto
- [Qemu-block] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 02/31] block: Use children list in bdrv_refresh_filename, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 01/31] block: Use bdrv_refresh_filename() to pull, Max Reitz, 2018/08/09
- Re: [Qemu-block] [PATCH for-3.1 v10 01/31] block: Use bdrv_refresh_filename() to pull,
Alberto Garcia <=
- [Qemu-block] [PATCH for-3.1 v10 03/31] block: Skip implicit nodes for filename info, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 04/31] block: Add BDS.auto_backing_file, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 06/31] iotests.py: Add filter_imgfmt(), Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 07/31] iotests.py: Add node_info(), Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 05/31] block: Respect backing bs in bdrv_refresh_filename, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 09/31] block: Make path_combine() return the path, Max Reitz, 2018/08/09