Re: [Qemu-block] [PATCH v3 19/19] test-bdrv-drain: Test draining job source child and parent

[Max Reitz]

On 20.09.18 18:19, Kevin Wolf wrote:
> For the block job drain test, don't only test draining the source and
> the target node, but create a backing chain for the source
> (source_backing <- source <- source_overlay) and test draining each of
> the nodes in it.
> 
> When using iothreads, the source node (and therefore the job) is in a
> different AioContext than the drain, which happens from the main
> thread. This way, the main thread waits in AIO_WAIT_WHILE() for the
> iothread to make process and aio_wait_kick() is required to notify it.
> The test validates that calling bdrv_wakeup() for a child or a parent
> node will actually notify AIO_WAIT_WHILE() instead of letting it hang.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/test-bdrv-drain.c | 75 
> +++++++++++++++++++++++++++++++++++++++++++------
>  1 file changed, 67 insertions(+), 8 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature