[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 6/6] nbd: forbid use of frozen bitmaps
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-block] [PATCH v4 6/6] nbd: forbid use of frozen bitmaps |
Date: |
Wed, 3 Oct 2018 14:06:18 +0000 |
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
03.10.2018 02:02, John Snow wrote:
> Whether it's "locked" or "frozen", it's in use and should
> not be allowed for the purposes of this operation.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> nbd/server.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/nbd/server.c b/nbd/server.c
> index c3dd402b45..940b7aa0cd 100644
> --- a/nbd/server.c
> +++ b/nbd/server.c
> @@ -2478,8 +2478,8 @@ void nbd_export_bitmap(NBDExport *exp, const char
> *bitmap,
> return;
> }
>
> - if (bdrv_dirty_bitmap_qmp_locked(bm)) {
> - error_setg(errp, "Bitmap '%s' is locked", bitmap);
> + if (bdrv_dirty_bitmap_user_locked(bm)) {
> + error_setg(errp, "Bitmap '%s' is in use", bitmap);
> return;
> }
>
--
Best regards,
Vladimir
- [Qemu-block] [PATCH v4 1/6] block/dirty-bitmaps: add user_locked status checker, (continued)
- [Qemu-block] [PATCH v4 3/6] block/dirty-bitmaps: allow clear on disabled bitmaps, John Snow, 2018/10/02
- [Qemu-block] [PATCH v4 6/6] nbd: forbid use of frozen bitmaps, John Snow, 2018/10/02
- [Qemu-block] [PATCH v4 2/6] block/dirty-bitmaps: fix merge permissions, John Snow, 2018/10/02
- [Qemu-block] [PATCH v4 5/6] block/backup: prohibit backup from using in use bitmaps, John Snow, 2018/10/02
- [Qemu-block] [PATCH v4 4/6] block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmaps, John Snow, 2018/10/02