Re: [Qemu-block] [PATCH v3 00/18] fleecing-hook driver for backup

[Eric Blake]

[redirecting this to NBD list]

On 10/3/18 10:36 AM, Vladimir Sementsov-Ogievskiy wrote:

> hmm, about different ports, it's funny, but NBD-spec is directly against
> different ports for new style negotiation:
> A client who wants to use the new style negotiation SHOULD connect on
> the IANA-reserved port for NBD, 10809. The server MAY listen on other
> ports as well, but it SHOULD use the old style handshake on those.
>
> also, next sentence is strange too:
> The server SHOULD refuse to allow oldstyle negotiations on the newstyle
> port.
>
> refuse? Refuse to whom? It's a server, who choose negotiation type. Or
> this means, that it should refuse to start at all. so refuse to server
> admin, not to NBD client? sounds strange. Should it be "Server SHOULD
> NOT use the old style on port 10809"?

We definitely need to tweak that wording, especially since we are trying 
to get rid of oldstyle servers and clients in favor of fixed newstyle.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org