[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 0/2] nbd server: drop old-style negotiation
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 0/2] nbd server: drop old-style negotiation |
Date: |
Wed, 3 Oct 2018 12:32:54 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/3/18 12:02 PM, Vladimir Sementsov-Ogievskiy wrote:
It's unexpected behavior that without -x option qemu-nbd do old-style
negotiation. Let's use "" as a default name instead (as it is already
done if tls is used) and therefore, drop old-style negotiation from
Qemu NBD server.
Oddly enough, I wrote a similar patch in parallel, and am only now just
seeing your mail. Yours is a bit stronger than mine (I added 'qemu-nbd
-O' to allow explicit fallback to oldstyle, while you ripped it out
altogether). The client can negotiate either style, so we don't need an
option on the client side; rather, this is all about what the server
should do by default.
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00568.html
Does anyone have a preference between the two? Here's the last time it
was discussed:
https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03252.html
Vladimir Sementsov-Ogievskiy (2):
qemu-nbd: drop old-style negotiation
nbd/server: drop old-style negotiation
include/block/nbd.h | 3 +--
blockdev-nbd.c | 2 +-
nbd/server.c | 53 +++++++++++++--------------------------------
qemu-nbd.c | 25 +++++----------------
4 files changed, 23 insertions(+), 60 deletions(-)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
Re: [Qemu-block] [PATCH 0/2] nbd server: drop old-style negotiation, Eric Blake, 2018/10/03