[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v11 24/31] block: Purify .bdrv_refresh_filename(
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH v11 24/31] block: Purify .bdrv_refresh_filename() |
|
Date: |
Thu, 11 Oct 2018 15:50:41 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Sat 06 Oct 2018 01:40:16 AM CEST, Max Reitz wrote:
> Currently, BlockDriver.bdrv_refresh_filename() is supposed to both
> refresh the filename (BDS.exact_filename) and set BDS.full_open_options.
> Now that we have generic code in the central bdrv_refresh_filename() for
> creating BDS.full_open_options, we can drop the latter part from all
> BlockDriver.bdrv_refresh_filename() implementations.
>
> This also means that we can drop all of the existing default code for
> this from the global bdrv_refresh_filename() itself.
>
> Furthermore, we now have to call BlockDriver.bdrv_refresh_filename()
> after having set BDS.full_open_options, because the block driver's
> implementation should now be allowed to depend on BDS.full_open_options
> being set correctly.
>
> Finally, with this patch we can drop the @options parameter from
> BlockDriver.bdrv_refresh_filename(); also, add a comment on this
> function's purpose in block/block_int.h while touching its interface.
>
> This completely obsoletes blklogwrite's implementation of
> .bdrv_refresh_filename().
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Berto
- [Qemu-block] [PATCH v11 16/31] quorum: Make bdrv_dirname() return NULL, (continued)
- [Qemu-block] [PATCH v11 16/31] quorum: Make bdrv_dirname() return NULL, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 18/31] block/nfs: Implement bdrv_dirname(), Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 19/31] block: Use bdrv_dirname() for relative filenames, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 22/31] block: Add BlockDriver.bdrv_gather_child_options, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 21/31] block: Add strong_runtime_opts to BlockDriver, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 23/31] block: Generically refresh runtime options, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 27/31] block/curl: Harmonize option defaults, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 26/31] block/nvme: Fix bdrv_refresh_filename(), Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 25/31] block: Do not copy exact_filename from format file, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 24/31] block: Purify .bdrv_refresh_filename(), Max Reitz, 2018/10/05
- Re: [Qemu-block] [PATCH v11 24/31] block: Purify .bdrv_refresh_filename(),
Alberto Garcia <=
- [Qemu-block] [PATCH v11 29/31] block/null: Generate filename even with latency-ns, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 28/31] block/curl: Implement bdrv_refresh_filename(), Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 30/31] block: BDS options may lack the "driver" option, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 31/31] iotests: Test json:{} filenames of internal BDSs, Max Reitz, 2018/10/05