[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] ping2 Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-block] ping2 Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic |
Date: |
Mon, 29 Oct 2018 17:52:09 +0000 |
ping2
Hi, what about this finally? Looks like everyone see a lot of comments
and thing, that there should be a new version, but actually, there is
almost unrelated discussion and/or answered questions. Only rephrasing
by Eric in patch 2 may be applied, to change something.
The series fix the bug in bitmaps migration, look at patch 5.
18.09.2018 13:37, Vladimir Sementsov-Ogievskiy wrote:
> 17.09.2018 21:33, John Snow wrote:
>>
>> On 09/17/2018 11:51 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> Hmm, ping, anybody here ?)
>>>
>> Was preparing to stage on Friday, working on it now.
>>
>> I never understood why you forbid the transfer of read only bitmaps
>> though, can you point that out for me?
>>
>> --js
>
> readonly bitmap - means it is not marked in_use in qcow2 file.
>
> Hm, I don't remember exact reason, but at least for shared migration
> it is unsafe to migrate readonly bitmap without special handling: we
> migrate it, it becomes not-readonly, it changes in RAM, then (assume)
> storing failed and we have old version ofthe bitmap in qcow2, which is
> not marked in_use.. So it should be somehow carefully handled, the
> simplest option is just to forbid it.
>
--
Best regards,
Vladimir
- [Qemu-block] ping2 Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic,
Vladimir Sementsov-Ogievskiy <=