|
From: | Alberto Garcia |
Subject: | Re: [Qemu-block] [PATCH v10 3/9] quorum: set supported write flags |
Date: | Fri, 07 Dec 2018 15:54:39 +0100 |
User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Fri 07 Dec 2018 03:46:13 PM CET, Anton Nefedov wrote: >>> +static void quorum_set_supported_flags(BlockDriverState *bs) >>> +{ >>> + BDRVQuorumState *s = bs->opaque; >>> + int i; >>> + >>> + bs->supported_write_flags = BDRV_REQ_FUA; >>> + for (i = 0; i < s->num_children; i++) { >>> + bs->supported_write_flags &= >>> s->children[i]->bs->supported_write_flags; >>> + } >>> + >>> + bs->supported_write_flags |= BDRV_REQ_WRITE_UNCHANGED; >>> +} >> >> You don't set supported_zero_flags here anymore ? > > Yes, I noticed (that late) that quorum doesn't actually implement > write_zeroes(). bdrv_co_do_pwrite_zeroes() specifically checks that > there must be no supported flags set in such case. Oh, I see. Reviewed-by: Alberto Garcia <address@hidden> Berto
[Prev in Thread] | Current Thread | [Next in Thread] |