[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 04/18] xen: create xenstore areas for XenDevi
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-block] [PATCH v2 04/18] xen: create xenstore areas for XenDevice-s |
Date: |
Fri, 7 Dec 2018 15:07:06 +0000 |
User-agent: |
Mutt/1.11.1 (2018-12-01) |
On Thu, Dec 06, 2018 at 03:08:30PM +0000, Paul Durrant wrote:
> This patch adds a new source module, xen-bus-helper.c, which builds on
> basic libxenstore primitives to provide functions to create (setting
> permissions appropriately) and destroy xenstore areas, and functions to
> 'printf' and 'scanf' nodes therein. The main xen-bus code then uses
> these primitives [1] to initialize and destroy the frontend and backend
> areas for a XenDevice during realize and unrealize respectively.
>
> The 'xen-block' implementation is extended with a 'get_name' method that
> returns the VBD number. This number is required to 'name' the xenstore
> areas.
>
> NOTE: An exit handler is also added to make sure the xenstore areas are
> cleaned up if QEMU terminates without devices being unrealized.
>
> [1] The 'scanf' functions are actually not yet needed, but they will be
> needed by code delivered in subsequent patches.
>
> Signed-off-by: Paul Durrant <address@hidden>
Looks good,
Reviewed-by: Anthony PERARD <address@hidden>
Thanks,
--
Anthony PERARD
- [Qemu-block] [PATCH v2 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, (continued)
- [Qemu-block] [PATCH v2 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/12/06
- [Qemu-block] [PATCH v2 09/18] xen: remove unnecessary code from dataplane/xen-block.c, Paul Durrant, 2018/12/06
- [Qemu-block] [PATCH v2 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-block.c, Paul Durrant, 2018/12/06
- [Qemu-block] [PATCH v2 06/18] xen: add grant table interface for XenDevice-s, Paul Durrant, 2018/12/06
- [Qemu-block] [PATCH v2 07/18] xen: add event channel interface for XenDevice-s, Paul Durrant, 2018/12/06
- [Qemu-block] [PATCH v2 04/18] xen: create xenstore areas for XenDevice-s, Paul Durrant, 2018/12/06
- Re: [Qemu-block] [PATCH v2 04/18] xen: create xenstore areas for XenDevice-s,
Anthony PERARD <=
- [Qemu-block] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Paul Durrant, 2018/12/06
- Re: [Qemu-block] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Anthony PERARD, 2018/12/07
- Re: [Qemu-block] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Paul Durrant, 2018/12/07
- Re: [Qemu-block] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Anthony PERARD, 2018/12/07
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Daniel P . Berrangé, 2018/12/07
- Re: [Qemu-block] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Paul Durrant, 2018/12/10
[Qemu-block] [PATCH v2 01/18] xen: re-name XenDevice to XenLegacyDevice..., Paul Durrant, 2018/12/06
[Qemu-block] [PATCH v2 15/18] xen: add a mechanism to automatically create XenDevice-s..., Paul Durrant, 2018/12/06
[Qemu-block] [PATCH v2 17/18] MAINTAINERS: add myself as a Xen maintainer, Paul Durrant, 2018/12/06