Re: [Qemu-block] [PATCH v3 0/3] dmg: fixing reading in dmg

[Stefan Hajnoczi]

On Thu, Jan 03, 2019 at 07:46:57PM +0800, yuchenlin wrote:
> There are two bugs in dmg reading.
> 
> First, it may hang in binary search. this problem is solved by patch 1.
> Second, because of lacking zero chunk table, reading zero sector will
> return EIO. this problem is solved by patch 2 and 3.
> 
> Thanks
> 
> v2 -> v3:
> * fix potential overflow (Thanks Stefan)
> * add Reviewed tag in patch 2 and 3
> 
> v1 -> v2:
> * fix typos in patch 1
> * add patch 2 and patch 3
> 
> yuchenlin (3):
>   dmg: fix binary search
>   dmg: use enumeration type instead of hard coding number
>   dmg: don't skip zero chunk
> 
>  block/dmg.c | 29 +++++++++++++++++++----------
>  1 file changed, 19 insertions(+), 10 deletions(-)
> 
> -- 
> 2.17.1
> 

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

signature.asc
Description: PGP signature