|
From: | Alberto Garcia |
Subject: | Re: [Qemu-block] [PATCH v2 1/1] include: Auto-generate the sizes lookup table |
Date: | Thu, 10 Jan 2019 13:51:43 +0100 |
User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 08 Jan 2019 01:20:21 PM CET, Kevin Wolf wrote: > During a downstream review, Max found a problem with the table that we > could fix while we're touching it: > > Upstream: All >= S_2GiB are not valid ints. (qemu assumes that > sizeof(int) == 4, right?) So S_2GiB should be 2147483648u and all > above should be ...ull or better UINT64_C(). Should it? sizeof(S_2GiB) is already 8 without having to add any suffix. Berto
[Prev in Thread] | Current Thread | [Next in Thread] |