[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/5] pflash: flush rom device me
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/5] pflash: flush rom device memory region |
|
Date: |
Fri, 25 Jan 2019 15:37:14 +0000 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Jan 25, 2019 at 10:36:17AM +0000, Peter Maydell wrote:
> On Fri, 25 Jan 2019 at 10:28, Stefan Hajnoczi <address@hidden> wrote:
> >
> > On Thu, Jan 24, 2019 at 12:11:55PM +0100, Philippe Mathieu-Daudé wrote:
> > > The device realize() is also executed before the guest is started, is
> > > this call really necessary?
> >
> > My rationale was that machine init only happens before the guest is
> > started while ->realize() is called by hotplug too.
>
> Yes, but before realize the flash memory can't actually be
> visible to the guest, so there's no need to invalidate anything.
>
> > That said, can pflash devices be hotplugged?
>
> I guess you could have one inside a hotplugged device in theory;
> they can't be directly hotpluggged. (I bet that in practice
> there are leaks though if you did do that, and we don't have
> any devices that do so today.)
>
> > If you guys prefer not flushing from pflash ->realize() then I'll drop
> > it.
>
> I think it makes more sense not to do a flush in the realize method.
Okay, I'll resend this patch.
Stefan
signature.asc
Description: PGP signature
[Qemu-block] [PATCH v2 1/5] memory: add memory_region_flush_rom_device(), Stefan Hajnoczi, 2019/01/23
[Qemu-block] [PATCH v2 3/5] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories, Stefan Hajnoczi, 2019/01/23
[Qemu-block] [PATCH v2 5/5] tests/microbit-test: Add tests for nRF51 NVMC, Stefan Hajnoczi, 2019/01/23
[Qemu-block] [PATCH v2 4/5] arm: Instantiate NRF51 special NVM's and NVMC, Stefan Hajnoczi, 2019/01/23
Re: [Qemu-block] [PATCH v2 0/5] arm: microbit Non-Volatile Memory Controller, Peter Maydell, 2019/01/24