[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] qtest.py: Wait for the result of qtest commands
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH] qtest.py: Wait for the result of qtest commands |
Date: |
Fri, 1 Feb 2019 13:44:43 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Am 31.01.2019 um 13:38 hat Alberto Garcia geschrieben:
> The cmd() method of the QEMUQtestProtocol class sends a qtest command
> to QEMU but doesn't wait for the return message ("OK", "FAIL", "ERR").
> Because of this, it can return control to the caller before the
> command has actually finished.
>
> In cases like clock_step or clock_set this means that cmd() can return
> before all the timers triggered by the clock change have been fired.
> This can be fixed by making cmd() wait for the output of the qtest
> command.
>
> This fixes iotests 093 and 136, which are flaky since commit
> 8258292e18c39480b64eba9f3551 when the machine is under heavy workload.
>
> Signed-off-by: Alberto Garcia <address@hidden>
Thanks, applied to the block branch.
Kevin