[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 01/12] block: Mark commit and mirror as filte
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v3 01/12] block: Mark commit and mirror as filter drivers |
Date: |
Fri, 15 Feb 2019 18:38:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 14.02.19 00:24, Eric Blake wrote:
> On 2/13/19 4:53 PM, Max Reitz wrote:
>> The commit and mirror block nodes are filters, so they should be marked
>> as such.
>>
>> Signed-off-by: Max Reitz <address@hidden>
>> Reviewed-by: Alberto Garcia <address@hidden>
>> ---
>> block/commit.c | 2 ++
>> block/mirror.c | 2 ++
>> 2 files changed, 4 insertions(+)
>
> Reviewed-by: Eric Blake <address@hidden>
>
> I know there are patches pending review for a backup driver (for image
> fleecing and otherwise), have you checked if that series would need
> similar treatment?
Good point; it is indeed marked as a filter driver from the start, so
we're good there.
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 12/12] iotests: Test committing to overridden backing, (continued)
- [Qemu-block] [PATCH v3 12/12] iotests: Test committing to overridden backing, Max Reitz, 2019/02/13
- [Qemu-block] [PATCH v3 07/12] iotests: Add tests for mirror @replaces loops, Max Reitz, 2019/02/13
- [Qemu-block] [PATCH v3 09/12] iotests: Add filter commit test cases, Max Reitz, 2019/02/13
- [Qemu-block] [PATCH v3 08/12] block: Leave BDS.backing_file constant, Max Reitz, 2019/02/13
- [Qemu-block] [PATCH v3 10/12] iotests: Add filter mirror test cases, Max Reitz, 2019/02/13
- [Qemu-block] [PATCH v3 06/12] block: Fix check_to_replace_node(), Max Reitz, 2019/02/13
- [Qemu-block] [PATCH v3 05/12] block: Inline bdrv_co_block_status_from_*(), Max Reitz, 2019/02/13
- [Qemu-block] [PATCH v3 04/12] block: Storage child access function, Max Reitz, 2019/02/13
- [Qemu-block] [PATCH v3 01/12] block: Mark commit and mirror as filter drivers, Max Reitz, 2019/02/13
- [Qemu-block] [PATCH v3 03/12] block: Filtered children access functions, Max Reitz, 2019/02/13
- [Qemu-block] [PATCH v3 02/12] blockdev: Check @replaces in blockdev_mirror_common, Max Reitz, 2019/02/13