[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] dataplane/xen-block: remove de
|
From: |
Anthony PERARD |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] dataplane/xen-block: remove dead code |
|
Date: |
Mon, 18 Feb 2019 14:27:31 +0000 |
|
User-agent: |
Mutt/1.11.3 (2019-02-01) |
On Fri, Feb 15, 2019 at 09:38:59PM +0100, Philippe Mathieu-Daudé wrote:
> On 2/15/19 5:25 PM, Paul Durrant wrote:
> > The if() statement is clearly bogus (dead code which should have been
> > cleaned up when grant mapping was removed).
>
> "... was removed in 06454c24ad)."
Actually, it looks like c6025bd197 should have remove the if statement.
> >
> > Spotted by Coverity: CID 1398635
> >
> > While in the neighbourhood, add a missing 'fall through' annotation.
> >
> > Reported-by: Peter Maydell <address@hidden>
> > Signed-off-by: Paul Durrant <address@hidden>
Acked-by: Anthony PERARD <address@hidden>
Thanks,
--
Anthony PERARD