[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] iotests: drop unnecessary accel=kvm
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-block] [PATCH] iotests: drop unnecessary accel=kvm |
|
Date: |
Tue, 19 Feb 2019 13:02:24 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 19/02/2019 12.59, Stefan Hajnoczi wrote:
> Tests 235 and 238 do not require the kvm accelerator. TCG works fine.
>
> Use the default accelerator instead of requiring kvm.
>
> Suggested-by: Thomas Huth <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> tests/qemu-iotests/235 | 1 -
> tests/qemu-iotests/238 | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/tests/qemu-iotests/235 b/tests/qemu-iotests/235
> index d6edd97ab4..329da8f0c2 100755
> --- a/tests/qemu-iotests/235
> +++ b/tests/qemu-iotests/235
> @@ -49,7 +49,6 @@ qemu_img_create('-f', iotests.imgfmt, '-o',
> 'preallocation=metadata', disk,
> str(size))
>
> vm = QEMUMachine(iotests.qemu_prog)
> -vm.add_args('-machine', 'accel=kvm')
According to the initial commit log of 235:
"iotests: simple mirror test with kvm on 1G image"
... so I assume KVM was used on purpose here?
Thomas