[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 04/10] virtio-net: make VirtIOFeature usable
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH v5 04/10] virtio-net: make VirtIOFeature usable for other virtio devices |
Date: |
Wed, 20 Feb 2019 16:00:33 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Feb 18, 2019 at 03:02:55PM +0100, Stefano Garzarella wrote:
> In order to use VirtIOFeature also in other virtio devices, we move
> its declaration and the endof() macro (renamed in virtio_endof())
> in virtio.h.
> We add virtio_feature_get_config_size() function to iterate the array
> of VirtIOFeature and to return the config size depending on the
> features enabled. (as virtio_net_set_config_size() did)
>
> Suggested-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Stefano Garzarella <address@hidden>
> ---
> hw/net/virtio-net.c | 31 +++++++------------------------
> hw/virtio/virtio.c | 15 +++++++++++++++
> include/hw/virtio/virtio.h | 15 +++++++++++++++
> 3 files changed, 37 insertions(+), 24 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-block] [PATCH v5 00/10] virtio-blk: add DISCARD and WRITE_ZEROES features, Stefano Garzarella, 2019/02/18
- [Qemu-block] [PATCH v5 01/10] virtio-blk: add acct_failed param to virtio_blk_handle_rw_error(), Stefano Garzarella, 2019/02/18
- [Qemu-block] [PATCH v5 02/10] virtio-blk: add host_features field in VirtIOBlock, Stefano Garzarella, 2019/02/18
- [Qemu-block] [PATCH v5 03/10] virtio-blk: add "discard" and "write-zeroes" properties, Stefano Garzarella, 2019/02/18
- [Qemu-block] [PATCH v5 04/10] virtio-net: make VirtIOFeature usable for other virtio devices, Stefano Garzarella, 2019/02/18
- Re: [Qemu-block] [PATCH v5 04/10] virtio-net: make VirtIOFeature usable for other virtio devices,
Stefan Hajnoczi <=
- [Qemu-block] [PATCH v5 05/10] virtio-blk: set config size depending on the features enabled, Stefano Garzarella, 2019/02/18
- [Qemu-block] [PATCH v5 07/10] tests/virtio-blk: change assert on data_size in virtio_blk_request(), Stefano Garzarella, 2019/02/18
- [Qemu-block] [PATCH v5 06/10] virtio-blk: add DISCARD and WRITE_ZEROES features, Stefano Garzarella, 2019/02/18
- [Qemu-block] [PATCH v5 08/10] tests/virtio-blk: add virtio_blk_fix_dwz_hdr() function, Stefano Garzarella, 2019/02/18
- [Qemu-block] [PATCH v5 09/10] tests/virtio-blk: add test for WRITE_ZEROES command, Stefano Garzarella, 2019/02/18
- [Qemu-block] [PATCH v5 10/10] tests/virtio-blk: add test for DISCARD command, Stefano Garzarella, 2019/02/18
- Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/10] virtio-blk: add DISCARD and WRITE_ZEROES features, no-reply, 2019/02/18