[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 01/10] block/dirty-bitmap: add recording and
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v3 01/10] block/dirty-bitmap: add recording and busy properties |
Date: |
Sat, 23 Feb 2019 14:06:54 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 2/22/19 6:06 PM, John Snow wrote:
> The current API allows us to report a single status, which we've defined as:
>
> Frozen: has a successor, treated as qmp_locked, may or may not be enabled.
> Locked: no successor, qmp_locked. may or may not be enabled.
> Disabled: Not frozen or locked, disabled.
> Active: Not frozen, locked, or disabled.
>
> The problem is that both "Frozen" and "Locked" mean nearly the same thing,
> and that both of them do not intuit whether they are recording guest writes
> or not.
>
> This patch deprecates that status field and introduces two orthogonal
> properties instead to replace it.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> +++ b/qemu-deprecated.texi
> @@ -67,6 +67,12 @@ topologies described with -smp include all possible cpus,
> i.e.
> "autoload" parameter is now ignored. All bitmaps are automatically loaded
> from qcow2 images.
>
> address@hidden query-block result field(s) dirty-bitmaps[i].status (since 4.0)
I suspect you wrote "field(s)" since there can be more than one
dirty-bitmaps[i]. But it still sound funny; within a single
dirty-bitmaps[i], there is only one field being deprecated. Dropping the
'(s)' makes this subsection read better to me.
That's minor enough that a maintainer could fix it, if you don't have
any other reason to spin v4.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [Qemu-block] [PATCH v3 00/10] dirty-bitmaps: deprecate @status field, John Snow, 2019/02/22
- [Qemu-block] [PATCH v3 02/10] block/dirty-bitmaps: rename frozen predicate helper, John Snow, 2019/02/22
- [Qemu-block] [PATCH v3 01/10] block/dirty-bitmap: add recording and busy properties, John Snow, 2019/02/22
- [Qemu-block] [PATCH v3 04/10] block/dirty-bitmap: change semantics of enabled predicate, John Snow, 2019/02/22
- [Qemu-block] [PATCH v3 08/10] block/dirty-bitmaps: move comment block, John Snow, 2019/02/22
- [Qemu-block] [PATCH v3 09/10] blockdev: remove unused paio parameter documentation, John Snow, 2019/02/22