[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/3] iotests: ask QEMU for supported formats
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH 2/3] iotests: ask QEMU for supported formats |
Date: |
Wed, 6 Mar 2019 19:07:09 +0100 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
Am 06.03.2019 um 18:59 hat Andrey Shinkevich geschrieben:
> On 06/03/2019 17:51, Kevin Wolf wrote:
> > This fixes it for me (the first hunk is actually a bonus which fixes a
> > preexisting bug, which somehow meant that the reason was not printed):
> >
> > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> > index e6ae4e91b7..b41ac4be51 100644
> > --- a/tests/qemu-iotests/iotests.py
> > +++ b/tests/qemu-iotests/iotests.py
> > @@ -712,7 +712,7 @@ def notrun(reason):
> > # Each test in qemu-iotests has a number ("seq")
> > seq = os.path.basename(sys.argv[0])
> >
> > - open('%s/%s.notrun' % (output_dir, seq), 'wb').write(reason + '\n')
> > + open('%s/%s.notrun' % (output_dir, seq), 'wt').write(reason + '\n')
> > print('%s not run: %s' % (seq, reason))
> > sys.exit(0)
> >
>
> Thanks a lot. I am going to add the fix above as a separate patch in v3
> with "Signed-off-by: Kevin Wolf <address@hidden>"
Sounds good to me, thanks!
Kevin